Otel exporter #529
Open
Otel exporter #529
+831
−273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor(session): simplify jwt check in session method
Signed-off-by: Teo <[email protected]>
Signed-off-by: Teo <[email protected]>
Signed-off-by: Teo <[email protected]>
Signed-off-by: Teo <[email protected]>
Signed-off-by: Teo <[email protected]>
teocns
force-pushed
the
otel-exporter
branch
from
9d5d952
to
bbbc6ec
Compare
teocns
force-pushed
the
otel-exporter
branch
from
bbbc6ec
to
e888b71
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: Teo <[email protected]>
Signed-off-by: Teo <[email protected]>
teocns
force-pushed
the
otel-exporter
branch
from
5bda685
to
2db1c5c
Compare
Signed-off-by: Teo <[email protected]>
Signed-off-by: Teo <[email protected]>
Signed-off-by: Teo <[email protected]>
Signed-off-by: Teo <[email protected]>
Signed-off-by: Teo <[email protected]>
Signed-off-by: Teo <[email protected]>
…ts own TracerProvider instance;; Shutdown flag is now instance-level Signed-off-by: Teo <[email protected]>
teocns
force-pushed
the
otel-exporter
branch
from
c9d52da
to
b68c1dc
Compare
Signed-off-by: Teo <[email protected]>
teocns
force-pushed
the
otel-exporter
branch
3 times, most recently
from
61ec901
to
711df42
Compare
delete(tests): remove conftest.py test configuration file refactor(session): remove unused resource and tracer provider methods
teocns
force-pushed
the
otel-exporter
branch
from
eaaafdb
to
894c846
Compare
areibman
previously requested changes
Nov 26, 2024
There was a problem hiding this comment.
Looks good. Seems we shaved off a lot of time! Just a few minor comments and I think we're good to ship this branch to keep things modular.
We're still getting latencies of around 0.4-1s. I think we can trim this down by skipping manual flushes on end_session and start_session. But let's save that for another PR
teocns
force-pushed
the
otel-exporter
branch
6 times, most recently
from
0d28c98
to
36a725e
Compare
teocns
force-pushed
the
otel-exporter
branch
from
b0f7e7e
to
793b196
Compare
Signed-off-by: Teo <[email protected]>
|
Season two streamed in #486 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significant performance boost for AgentOps SDK by leveraging on OpenTelemetry as an event publisher
Additioanlly fixes
vcrpyinstalling old version and erroring due torequires-python >= 3.7